Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.

View Change

5 comments:

• File src/mainboard/google/geralt/panel.c:

  • Patch Set #3, Line 27:

    if (!panel || panel->disp_path == DISP_PATH_NONE) {
    		printk(BIOS_ERR, "%s: Panel %u is not supported.\n", __func__, active_panel_id);
    		return NULL;
    	}
    

    I think the check can also be moved to `mtk_display_init()`.

    Done

• File src/soc/mediatek/common/display.c:

  • Patch Set #3, Line 15: void

    Can we return the pointer `&buffer. […]

    Done

  • Patch Set #3, Line 88: (

    nit: No need for parentheses.

    Done

• File src/soc/mediatek/common/include/soc/display.h:

  • Patch Set #3, Line 20: struct

    const

    Done

• File src/soc/mediatek/mt8188/include/soc/ddp.h:

  • Patch Set #3, Line 286:

    void mtk_ddp_init(void);
    void mtk_ddp_mode_set(const struct edid *edid, enum disp_path_sel path);
    

    Since these 2 functions are called from common/display. […]

    Done

To view, visit change 79776. To unsubscribe, or for help writing mail filters, visit settings.