4 comments:
File src/soc/mediatek/common/flash_controller.c:
Patch Set #2, Line 139: #if CONFIG(SOC_MEDIATEK_MT8173)
can we rewrite as
if (CONFIG(SOC_MEDIATEK_MT817)) {
if (!ENV_BOOTBLOCK && !ENV_SEPARATE_VERSTAGE) {
...
}
}
dma_buf = (uintptr_t)_dma_coherent;
dma_buf_len = REGION_SIZE(dma_coherent);
that's already the default value
#if CONFIG(FLASH_DUAL_READ_SUPPORTED)
setbits8(&mtk_nor->read_dual, SFLASH_READ_DUAL_EN);
write8(&mtk_nor->prgdata[3], SFLASH_1_1_2_READ);
#endif
can we replace this by
if (CONFIG(FLASH_DUAL_READ_SUPPORTED)) {
setbits8...
write8...
}
File src/soc/mediatek/mt8192/Kconfig:
Patch Set #2, Line 78: _SUPPORTED
We usually don't add 'SUPPORTED' in config. Just call it FLASH_DUAL_READ ?
To view, visit change 48972. To unsubscribe, or for help writing mail filters, visit settings.