Patch Set 1:

AmdGetValue() was invalid in the first place, it is not part of AGESA specification and was already removed during amd/stoneyridge reviews from that PI build.

That cpu_bus_scan() uses is just wrong and probably does not even do what it is supposed to.

Any suggestions on how to rewrite the cpu_bus_scan? What would be the best approach?

View Change

To view, visit change 32421. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I700a7d8d3c77ee0525b2c764c720ab5bf39925f8
Gerrit-Change-Number: 32421
Gerrit-PatchSet: 2
Gerrit-Owner: Krystian Hebel <krystian.hebel@3mdeb.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel@3mdeb.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 04 Oct 2019 11:28:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment