Attention is currently required from: Sean Rhodes, Matt DeVillier, Stefan Reinauer.
View Change
2 comments:
Commit Message:
Patch Set #1, Line 9: Pass build directory of `Build/coreboot` so all variants will output to the
reflow to < 75 characters?
Patchset:
Patch Set #1:
If we can have it build somewhere other than the project directory, that'd probably be useful. coreboot's makefile has the variable ${obj} which can be adjusted. Maybe we look at making all of the payloads build in coreboot/build/payloads/<PAYLOAD_NAMD> by default.
Not necessary now, and I'm not trying to voluntell you to do this, just a thought.
To view, visit change 61572. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I055f7fb13c7b5f7f1703230e329160da2ef3f137
Gerrit-Change-Number: 61572
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean@starlabs.systems>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Sean Rhodes <sean@starlabs.systems>
Gerrit-Attention: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Comment-Date: Thu, 03 Feb 2022 16:52:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment