Attention is currently required from: Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Stefan Reinauer, Kyösti Mälkki, Andrey Petrov, Patrick Rudolph, Nico Huber, Anjaneya "Reddy" Chagam, Johnny Lin, Suresh Bellampalli, Morgan Jang, Michal Motyl, Alexander Couzens, Felix Held, Furquan Shaikh, Angel Pons, Lance Zhao, Jason Glenesk, Martin Roth, Damien Zammit, Lee Leahy, Marshall Dawson, Tim Wawrzynczak, Vanessa Eusebio, Huang Jin.
View Change
1 comment:
Patchset:
Patch Set #5:
My three questions above are still unanswered. And the parent commit […]
Nico, can you please read the design doc that I wrote up and referenced above (https://review.coreboot.org/c/coreboot/+/57861) and see if you still have concerns regarding the steps that we are taking to implement the non-ECAM PCI config access mechanism? I've listed out the four steps that we are planning on taking to achieve this. All the current CLs are WIP and will be modified to reflect the changes in the doc when it is approved. Please comment on the doc for the things that you disagree with.
specifically regarding your questions:
1. Does QC actually call their mechanism MMCONF(IG)?
This seems to be a kernel/coreboot thing. QC seems to be using it as well. See https://review.coreboot.org/c/coreboot/+/57614
Does any other project use the MMCONF term for more than coreboot currently does?
The linux kernel uses the MMConfig term. See: https://cateee.net/lkddb/web-lkddb/PCI_MMCONFIG.html. I think that coreboot/linux are using it to refer to the same thing.
What does/should the term MMCONF comprise? Isn't it it about (directly) memory mapping PCI(e) config space? which QC doesn't do, as it seems
MMConfig is referring to the PCIe config space. QC is using the PCIe space, as you can see in https://review.coreboot.org/c/coreboot/+/57614, for NVMe. They are just not using ECAM to access it, which is the reason that we're doing this redesign.
To view, visit change 57333. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e196a1ed52d131a71f00cba1d93a23e54aca3e2
Gerrit-Change-Number: 57333
Gerrit-PatchSet: 8
Gerrit-Owner: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Huang Jin <huang.jin@intel.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy@intel.com>
Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski@intel.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Michal Motyl <michalx.motyl@intel.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang@wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski@intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Attention: Patrick Rudolph <siro@das-labor.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli@intel.com>
Gerrit-Attention: Morgan Jang <Morgan_Jang@wiwynn.com>
Gerrit-Attention: Michal Motyl <michalx.motyl@intel.com>
Gerrit-Attention: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Attention: Furquan Shaikh <furquan@google.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Attention: Martin Roth <martinroth@google.com>
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Lee Leahy <leroy.p.leahy@intel.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Attention: Huang Jin <huang.jin@intel.com>
Gerrit-Comment-Date: Wed, 06 Oct 2021 18:08:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Gerrit-MessageType: comment