Can this be tested in QEMU (with SeaVGABIOS(?))?

i believe yes, it can be tested.

Not as easy as I though it would be. Qemu emulates an external graphics
card by default and includes the option ROM. However, coreboot makes it
hard to use (for reasons I don't understand, CB:4258). It's easy to patch
(see below).

With this config:

    CONFIG_VGA_ROM_RUN=y
CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
CONFIG_FRAMEBUFFER_VESA_MODE_USER=y
CONFIG_FRAMEBUFFER_VESA_MODE=0x1234

I get this:

    $ qemu-system-i386 -bios build/coreboot.rom -serial stdio
[...]
PCI: 00:02.0 init ...
CBFS: 'Master Header Locator' located CBFS at [200:40000)
CBFS: Locating 'pci1234,1111.rom'
CBFS: 'pci1234,1111.rom' not found.
Option ROM address for PCI: 00:02.0 = fe060000
Copying VGA ROM Image from fe060000 to 0xc0000, 0x9600 bytes
Calling Option ROM...
... Option ROM returned.
VBE: Getting information about VESA mode 5234
VBE: Function call failed!
    Error: In vbe_get_mode_info function

Which seems correct regarding VBE spec. But it dies before it can
show the list of supported video modes :-(


diff --git a/src/drivers/emulation/qemu/Kconfig b/src/drivers/emulation/qemu/Kconfig
index 58daaa4487..e1c11a1479 100644
--- a/src/drivers/emulation/qemu/Kconfig
+++ b/src/drivers/emulation/qemu/Kconfig
@@ -1,5 +1,5 @@
config DRIVERS_EMULATION_QEMU_BOCHS
- bool "bochs dispi interface vga driver"
+ bool
default y
depends on BOARD_EMULATION_QEMU_X86
depends on MAINBOARD_DO_NATIVE_VGA_INIT
diff --git a/src/mainboard/emulation/qemu-i440fx/Kconfig b/src/mainboard/emulation/qemu-i440fx/Kconfig
index 23526f96d9..e24196bcc4 100644
--- a/src/mainboard/emulation/qemu-i440fx/Kconfig
+++ b/src/mainboard/emulation/qemu-i440fx/Kconfig
@@ -11,7 +11,6 @@ config BOARD_SPECIFIC_OPTIONS
select HAVE_ACPI_TABLES
select BOARD_ROMSIZE_KB_256
select MAINBOARD_HAS_NATIVE_VGA_INIT
- select MAINBOARD_FORCE_NATIVE_VGA_INIT
select POSTCAR_STAGE
select POSTCAR_CONSOLE

View Change

To view, visit change 34284. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02cba44374bc50ec3ec2819c97b6f5027c58387f
Gerrit-Change-Number: 34284
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 20 Jul 2019 12:25:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment