Attention is currently required from: Lance Zhao, Nico Huber, Maxim Polyakov, Johnny Lin, Patrick Rudolph.
8 comments:
Commit Message:
Patch Set #13, Line 11: intertool
typo: inte*l*tool
File util/inteltool/cpu.c:
Patch Set #13, Line 2300: range_end != (unsigned int)(-1)
uh... Use UINT_MAX?
File util/inteltool/inteltool.c:
Patch Set #13, Line 520: range
How about naming this option `cpu-range`? This should avoid name clashes if anyone wants to add another range option in the future.
Patch Set #13, Line 590: (unsigned int)(-1)
UINT_MAX
Patch Set #13, Line 666: if (!dump_coremsrs) {
AFAIUI, this will bail out if --range is specified before -M. I'd move this check out of the argument parsing loop.
errno = 0;
if (strlen(optarg) == 0 || errno) {
What do you use `errno` for here?
Patch Set #13, Line 676: sscanf(optarg, "%u-%u", &cores_range_start, &cores_range_end);
The sscanf function returns the value of the macro EOF if an input failure occurs before any conversion. Otherwise, the sscanf function returns the number of input items assigned, which can be fewer than provided for, or even zero, in the event of an early matching failure.
Please handle this function's return value.
Patch Set #13, Line 681: } else if (cores_range_end == (unsigned int)(-1)) {
Please use the return value of `sscanf()` to handle this instead of repeating a magic number.
To view, visit change 35919. To unsubscribe, or for help writing mail filters, visit settings.