Attention is currently required from: Tim Chu.
Patch set 6:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #6:
This PR itself looks good to me.
That being said, the FspmUpd.h file has wrong comments (auto generated during FSP build process). Tim, please open an IPS ticket to track it:
/** Offset 0x00C1 - Processor X2apic Function
Enable(Default) or Disable Processor X2apic Function
$EN_DIS
**/
UINT8 X2apic;
/** Offset 0x00C2 - DDR frequency limit
Enable(Default) or Disable Processor X2apic Function
**/
UINT8 DdrFreqLimit;
/** Offset 0x00C3 - Memory Serial Debug Message Level
Enable(Default) or Disable Processor X2apic Function
**/
UINT8 serialDebugMsgLvl;
To view, visit change 48946. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1232feae5090420d8fa42596b46f2d4dcaf9d635
Gerrit-Change-Number: 48946
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang@wiwynn.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Ryback Hung <ryback.hung%quantatw.com@gtempaccount.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Tim Chu <Tim.Chu@quantatw.com>
Gerrit-Comment-Date: Wed, 10 Mar 2021 17:08:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment