Patch Set 4:

Any reason to prefer Kconfig over Makefile? Kconfig is useful if you want some kind of dependency handling or include a set of files in one line, but if it's just to include one file it seems like overkill?

If one wants to rename the cache.c file or relocate it, then one has to update all Makefile.inc accordingly. This is rather ugly. Plus, I plan on selecting some of these options from other symbols, which should simplify things a bit. Having the same Kconfig name everywhere instead of variable build rules makes it easier to grep for things.

View Change

To view, visit change 44226. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b9b29a158c34a30480aaabf6d0b23819d28427
Gerrit-Change-Number: 44226
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Reviewer: David Guckian <david.guckian@intel.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 09 Aug 2020 07:56:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment