Felix Held submitted this change.

View Change

Approvals: Daniel Peng: Looks good to me, but someone else must approve build bot (Jenkins): Verified Derek Huang: Looks good to me, approved
mb/google/dedede/var/galtic: Support for Samsung K4U6E3S4AB-MGCL

Add the new memory support:
Samsung K4U6E3S4AB-MGCL

BUG=b:320137193
BRANCH=firmware-dedede-13606.B
TEST=Run command "go run ./util/spd_tools/src/part_id_gen/\
part_id_gen.go JSL lp4x \
src/mainboard/google/dedede/variants/galtic/memory/ \
src/mainboard/google/dedede/variants/galtic/memory/\
mem_parts_used.txt"

Change-Id: I3f6c784a194e141a3dd1e5a37b3cf12106e692d6
Signed-off-by: Daniel Peng <Daniel_Peng@pegatron.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80150
Reviewed-by: Daniel Peng <daniel_peng@pegatron.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Derek Huang <derekhuang@google.com>
---
M src/mainboard/google/dedede/variants/galtic/memory/Makefile.mk
M src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt
M src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/google/dedede/variants/galtic/memory/Makefile.mk b/src/mainboard/google/dedede/variants/galtic/memory/Makefile.mk
index b4a4e64..5154e6e 100644
--- a/src/mainboard/google/dedede/variants/galtic/memory/Makefile.mk
+++ b/src/mainboard/google/dedede/variants/galtic/memory/Makefile.mk
@@ -1,9 +1,9 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
# Generated by:
-# /tmp/go-build591443712/b001/exe/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/galtic/memory/ src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
+# /tmp/go-build378545252/b001/exe/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/galtic/memory/ src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt

SPD_SOURCES =
-SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 0(0b0000) Parts = H9HCNNNBKMMLXR-NEE, MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR
+SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 0(0b0000) Parts = H9HCNNNBKMMLXR-NEE, MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR, K4U6E3S4AB-MGCL
SPD_SOURCES += spd/lp4x/set-1/spd-4.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:A
SPD_SOURCES += spd/lp4x/set-1/spd-3.hex # ID = 2(0b0010) Parts = H9HCNNNCPMMLXR-NEE
diff --git a/src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt
index 73b84c1..8c8acfa 100644
--- a/src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt
+++ b/src/mainboard/google/dedede/variants/galtic/memory/dram_id.generated.txt
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
# Generated by:
-# /tmp/go-build591443712/b001/exe/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/galtic/memory/ src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
+# /tmp/go-build378545252/b001/exe/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/galtic/memory/ src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt

DRAM Part Name ID to assign
H9HCNNNBKMMLXR-NEE 0 (0000)
@@ -9,3 +9,4 @@
K4U6E3S4AA-MGCR 0 (0000)
MT53E1G32D2NP-046 WT:A 1 (0001)
H9HCNNNCPMMLXR-NEE 2 (0010)
+K4U6E3S4AB-MGCL 0 (0000)
diff --git a/src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
index 816c1b0..17b8266 100644
--- a/src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
+++ b/src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
@@ -9,3 +9,4 @@
K4U6E3S4AA-MGCR
MT53E1G32D2NP-046 WT:A
H9HCNNNCPMMLXR-NEE
+K4U6E3S4AB-MGCL

To view, visit change 80150. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f6c784a194e141a3dd1e5a37b3cf12106e692d6
Gerrit-Change-Number: 80150
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Peng <daniel_peng@pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng@pegatron.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang@google.com>
Gerrit-Reviewer: Edward Dai <edwarddai@google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Ivan Chen <yulunchen@google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin@pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu@pegatron.corp-partner.google.com>
Gerrit-MessageType: merged