Patch set 9:Code-Review +1
5 comments:
Patch Set #6, Line 14: TEST=emerge-volteer coreboot
The most important question is: does it boot? 😄
Done
File src/mainboard/google/volteer/variants/lingcod/gpio.c:
Patch Set #6, Line 136: USER_PRES_FP_ODL
No, the correct is USER_PRES_FP_ODL
Ack
/* S6 : SNDW3_CLK ==> DMIC_CLK0 */
PAD_CFG_NF(GPP_S6, NONE, DEEP, NF1),
/* S7 : SNDW3_DATA ==> DMIC_DATA0 */
PAD_CFG_NF(GPP_S7, NONE, DEEP, NF1),
Sorry, it is NF2, not NF1.
Done
File src/mainboard/google/volteer/variants/lingcod/overridetree.cb:
Patch Set #6, Line 3: device domain 0 on
GSPI1 has been disabled, like gpio. […]
Ack
File src/mainboard/google/volteer/variants/lingcod/overridetree.cb:
Patch Set #9, Line 23: register "SerialIoI2cMode" = "{
Nit: I think this has to define all SerialIO devices. It's an array, so uninitialized elements will be zero
To view, visit change 43442. To unsubscribe, or for help writing mail filters, visit settings.