Attention is currently required from: Alexander Couzens.
Felix Singer has uploaded this change for review.
mb/lenovo/t430: Remove superfluous comments related to PCI devices
Since all devicetrees from lenovo/t430 are using the reference names for
PCI devices now, remove the equivalent comments documenting their
function.
Change-Id: I84f432e89c41a02115715f7f1b56123dd0d81171
Signed-off-by: Felix Singer <felixsinger@posteo.net>
---
M src/mainboard/lenovo/t430s/devicetree.cb
M src/mainboard/lenovo/t430s/variants/t430s/overridetree.cb
M src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb
3 files changed, 33 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/79942/1
diff --git a/src/mainboard/lenovo/t430s/devicetree.cb b/src/mainboard/lenovo/t430s/devicetree.cb
index 23a41d6..fae1871 100644
--- a/src/mainboard/lenovo/t430s/devicetree.cb
+++ b/src/mainboard/lenovo/t430s/devicetree.cb
@@ -17,9 +17,9 @@
device domain 0 on
subsystemid 0x17aa 0x21fb inherit
- device ref host_bridge on end # host bridge
- device ref peg10 on end # PCIe Bridge for discrete graphics
- device ref igd on end # Integrated Graphics Controller
+ device ref host_bridge on end
+ device ref peg10 on end # Discrete graphics
+ device ref igd on end
chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH
# GPI routing
@@ -52,28 +52,28 @@
register "spi_uvscc" = "0x2005"
register "spi_lvscc" = "0x2005"
- device ref xhci on end # USB 3.0 Controller
- device ref mei1 on end # Management Engine Interface 1
- device ref mei2 off end # Management Engine Interface 2
- device ref me_ide_r off end # Management Engine IDE-R
- device ref me_kt off end # Management Engine KT
+ device ref xhci on end
+ device ref mei1 on end
+ device ref mei2 off end
+ device ref me_ide_r off end
+ device ref me_kt off end
device ref gbe on
subsystemid 0x17aa 0x21f3
- end # Intel Gigabit Ethernet
- device ref ehci2 on end # USB Enhanced Host Controller #2
- device ref hda on end # High Definition Audio Controller
- device ref pcie_rp1 off end # PCIe Port #1
- device ref pcie_rp2 on end # PCIe Port #2 Integrated Wireless LAN
+ end
+ device ref ehci2 on end
+ device ref hda on end
+ device ref pcie_rp1 off end
+ device ref pcie_rp2 on end # Integrated Wireless LAN
device ref pcie_rp3 on
smbios_slot_desc "7" "3" "ExpressCard Slot" "8"
- end # PCIe Port #3 ExpressCard
- device ref pcie_rp4 off end # PCIe Port #4
- device ref pcie_rp5 off end # PCIe Port #5
- device ref pcie_rp6 off end # PCIe Port #6 Intel Gigabit Ethernet PHY (not PCIe)
- device ref pcie_rp7 off end # PCIe Port #7
- device ref pcie_rp8 off end # PCIe Port #8
- device ref ehci1 on end # USB Enhanced Host Controller #1
- device ref pci_bridge off end # PCI bridge
+ end
+ device ref pcie_rp4 off end
+ device ref pcie_rp5 off end
+ device ref pcie_rp6 off end # Intel Gigabit Ethernet PHY (not PCIe)
+ device ref pcie_rp7 off end
+ device ref pcie_rp8 off end
+ device ref ehci1 on end
+ device ref pci_bridge off end
device ref lpc on
chip ec/lenovo/pmh7
device pnp ff.1 on end # dummy
@@ -117,8 +117,8 @@
register "eventd_enable" = "0xff"
register "evente_enable" = "0x0d"
end
- end # LPC Controller
- device ref sata1 on end # 6 port SATA AHCI Controller
+ end
+ device ref sata1 on end
device ref smbus on
# eeprom, 8 virtual devices, same chip
chip drivers/i2c/at24rf08c
@@ -131,9 +131,9 @@
device i2c 5e on end
device i2c 5f on end
end
- end # SMBus Controller
- device ref sata2 off end # SATA Controller 2
- device ref thermal on end # Thermal
+ end
+ device ref sata2 off end
+ device ref thermal on end
end
end
end
diff --git a/src/mainboard/lenovo/t430s/variants/t430s/overridetree.cb b/src/mainboard/lenovo/t430s/variants/t430s/overridetree.cb
index 2515150..5677a87 100644
--- a/src/mainboard/lenovo/t430s/variants/t430s/overridetree.cb
+++ b/src/mainboard/lenovo/t430s/variants/t430s/overridetree.cb
@@ -4,7 +4,7 @@
chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH
# Enable hotplug on Port 5 for Thunderbolt controller
register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 1, 0, 0, 0 }"
- device ref pcie_rp5 on end # PCIe Port #5 Thunderbolt controller
+ device ref pcie_rp5 on end # Thunderbolt controller
device ref lpc on
chip ec/lenovo/h8
device pnp ff.2 on end # dummy
@@ -12,7 +12,7 @@
register "bdc_gpio_num" = "54"
register "bdc_gpio_lvl" = "0"
end
- end # LPC Controller
+ end
end
end
end
diff --git a/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb b/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb
index 3e13627..c9d3c0f 100644
--- a/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb
+++ b/src/mainboard/lenovo/t430s/variants/t431s/overridetree.cb
@@ -15,7 +15,7 @@
device domain 0 on
subsystemid 0x17aa 0x2208 inherit
- device ref peg10 off end # PCIe Bridge for discrete graphics
+ device ref peg10 off end
chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH
# Enable SATA ports 0 (HDD bay) & 1 (WWAN M.2 SATA) & 4 (dock)
@@ -23,14 +23,14 @@
# T431s has no Express Card slot.
register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"
- device ref pcie_rp1 on # PCIe Port #1
+ device ref pcie_rp1 on
chip drivers/ricoh/rce822 # Ricoh cardreader
register "disable_mask" = "0x87"
register "sdwppol" = "0"
device pci 00.0 on end # Ricoh SD card reader
end
end
- device ref pcie_rp3 off end # PCIe Port #3
+ device ref pcie_rp3 off end
device ref lpc on
chip ec/lenovo/h8
device pnp ff.2 on end # dummy
@@ -41,8 +41,8 @@
# T431s only has BT on wlan card
register "has_bdc_detection" = "0"
end
- end # LPC Controller
- device ref thermal off end # Thermal
+ end
+ device ref thermal off end
end
end
end
To view, visit change 79942. To unsubscribe, or for help writing mail filters, visit settings.