Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41440 )
Change subject: sconfig: Add support for firmware configuration ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41440/14/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/41440/14/util/sconfig/main.c@1495 PS14, Line 1495:
I did this intentionally because this allows an override to remove all the probe entries and/or defi […]
The downside is that an override has to keep that in mind and define the probe list every time it wants to override a device for anything, which is not great either..
https://review.coreboot.org/c/coreboot/+/41440/14/util/sconfig/sconfig.h File util/sconfig/sconfig.h:
https://review.coreboot.org/c/coreboot/+/41440/14/util/sconfig/sconfig.h@11 PS14, Line 11:
nit: extra blank line not required.
Done