Attention is currently required from: Nico Huber, Benjamin Doron, Paul Menzel, Patrick Rudolph.

Angel Pons uploaded patch set #7 to this change.

View Change

[WIP] soc/intel/common: Add InSMM.STS support

Tested on HP 280 G2, SMMSTORE (v1) still works.

Other tests:
- If one does not set BIOS_CONTROL bit WPD, SMMSTORE breaks.
- If one does not write the magic MSR `or 1`, SMMSTORE breaks.

Change-Id: Ia90c0e3f8ccf895bfb6d46ffe26750393dab95fb
Signed-off-by: Angel Pons <>
M src/soc/intel/common/block/smm/smihandler.c
M src/soc/intel/common/pch/lockdown/lockdown.c
2 files changed, 27 insertions(+), 4 deletions(-)

git pull ssh:// refs/changes/96/51796/7

To view, visit change 51796. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia90c0e3f8ccf895bfb6d46ffe26750393dab95fb
Gerrit-Change-Number: 51796
Gerrit-PatchSet: 7
Gerrit-Owner: Angel Pons <>
Gerrit-Reviewer: Michael Niewöhner <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Benjamin Doron <>
Gerrit-CC: Nico Huber <>
Gerrit-CC: Paul Menzel <>
Gerrit-Attention: Nico Huber <>
Gerrit-Attention: Benjamin Doron <>
Gerrit-Attention: Paul Menzel <>
Gerrit-Attention: Patrick Rudolph <>
Gerrit-MessageType: newpatchset