Attention is currently required from: Martin L Roth, Stefan Reinauer.
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
View Change
2 comments:
File util/lint/lint:
Patch Set #1, Line 25: # Look if we have getopt. If not, build it.
Could you move these lines below junit_write()? Then the functions stay in line.
Patch Set #1, Line 29: --
This seems wrong here. The double dash is still present below.
To view, visit change 80436. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife26083d2de080af9ed3d509945720051ca14bd7
Gerrit-Change-Number: 80436
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless@gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Comment-Date: Fri, 09 Feb 2024 16:27:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment