Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30957 )
Change subject: superio/ite: Add it8528e
......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/30957/6/src/superio/ite/it8528e/sup...
File src/superio/ite/it8528e/superio.c:
https://review.coreboot.org/c/coreboot/+/30957/6/src/superio/ite/it8528e/sup...
PS6, Line 44: 0xfff0
0xffe0
https://review.coreboot.org/c/coreboot/+/30957/6/src/superio/ite/it8528e/sup...
PS6, Line 60: 0x07ff, 0x07ff
this differes from PMC1-4: 0x0fff, 0x0fff
https://review.coreboot.org/c/coreboot/+/30957/6/src/superio/ite/it8528e/sup...
PS6, Line 61: 0xfff8
should be 0x0ffc according to datasheet
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30957
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72aa756e123d6f99d9ef4fe955c4b7f1be25d547
Gerrit-Change-Number: 30957
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sat, 26 Dec 2020 22:34:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
