Subrata Banik submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: Eric Lai: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve build bot (Jenkins): Verified
mb/google/brya: Standardize TPM TIS ACPI interrupt configuration

This patch sets a default value of 13 (GPE0_DW0_13/GPP_A13_IRQ) for
the `TPM_TIS_ACPI_INTERRUPT` configuration option across most Google
Brya variants. The HADES board uses interrupt 20 (GPE0_DW0_20/
GPP_A20_IRQ), and the ORISA board uses interrupt 17 (GPE0_DW0_17/
GPP_A17_IRQ).

This refactoring simplifies future additions of board-specific TPM
interrupt configurations, improving maintainability.

BUG=none
TEST=The timeless builds with this patch for both Nissa and Brya
devices produce the same binaries.

Change-Id: I9d913bf3da6957ab5c700dd746bc4b5350427d73
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83493
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/brya/Kconfig
1 file changed, 59 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig
index e235fec..10ae55f 100644
--- a/src/mainboard/google/brya/Kconfig
+++ b/src/mainboard/google/brya/Kconfig
@@ -724,9 +724,66 @@

config TPM_TIS_ACPI_INTERRUPT
int
+ default 13 if BOARD_GOOGLE_AGAH # GPE0_DW0_13 (GPP_A13_IRQ)
+ default 13 if BOARD_GOOGLE_ANAHERA
+ default 13 if BOARD_GOOGLE_ANAHERA4ES
+ default 13 if BOARD_GOOGLE_ANRAGGAR
+ default 13 if BOARD_GOOGLE_AURASH
+ default 13 if BOARD_GOOGLE_BANSHEE
+ default 13 if BOARD_GOOGLE_BRASK
+ default 13 if BOARD_GOOGLE_BRYA0
+ default 13 if BOARD_GOOGLE_BUJIA
+ default 13 if BOARD_GOOGLE_CONSTITUTION
+ default 13 if BOARD_GOOGLE_CRAASK
+ default 13 if BOARD_GOOGLE_CRAASKOV
+ default 13 if BOARD_GOOGLE_CROTA
+ default 13 if BOARD_GOOGLE_DOCHI
+ default 13 if BOARD_GOOGLE_DOMIKA
+ default 13 if BOARD_GOOGLE_FELWINTER
+ default 13 if BOARD_GOOGLE_GAELIN
+ default 13 if BOARD_GOOGLE_GIMBLE
+ default 13 if BOARD_GOOGLE_GIMBLE4ES
+ default 13 if BOARD_GOOGLE_GLADIOS
+ default 13 if BOARD_GOOGLE_GLASSWAY
+ default 13 if BOARD_GOOGLE_GOTHRAX
+ default 20 if BOARD_GOOGLE_HADES # GPE0_DW0_20 (GPP_A20_IRQ)
+ default 13 if BOARD_GOOGLE_JOXER
+ default 13 if BOARD_GOOGLE_KANO
+ default 13 if BOARD_GOOGLE_KINOX
+ default 13 if BOARD_GOOGLE_KULDAX
+ default 13 if BOARD_GOOGLE_LISBON
+ default 13 if BOARD_GOOGLE_MARASOV
+ default 13 if BOARD_GOOGLE_MITHRAX
+ default 13 if BOARD_GOOGLE_MOLI
+ default 13 if BOARD_GOOGLE_NEREID
+ default 13 if BOARD_GOOGLE_NIVVIKS
+ default 13 if BOARD_GOOGLE_NOVA
+ default 13 if BOARD_GOOGLE_OMNIGUL
default 17 if BOARD_GOOGLE_ORISA # GPE0_DW0_17 (GPP_A17_IRQ)
- default 20 if BOARD_GOOGLE_BASEBOARD_HADES # GPE0_DW0_20 (GPP_A20_IRQ)
- default 13 if !BOARD_GOOGLE_BASEBOARD_HADES # GPE0_DW0_13 (GPP_A13_IRQ)
+ default 13 if BOARD_GOOGLE_OSIRIS
+ default 13 if BOARD_GOOGLE_PIRRHA
+ default 13 if BOARD_GOOGLE_PRIMUS
+ default 13 if BOARD_GOOGLE_PUJJO
+ default 13 if BOARD_GOOGLE_QUANDISO
+ default 13 if BOARD_GOOGLE_REDRIX
+ default 13 if BOARD_GOOGLE_REDRIX4ES
+ default 13 if BOARD_GOOGLE_RIVEN
+ default 13 if BOARD_GOOGLE_SKOLAS
+ default 13 if BOARD_GOOGLE_SKOLAS4ES
+ default 13 if BOARD_GOOGLE_TAEKO
+ default 13 if BOARD_GOOGLE_TAEKO4ES
+ default 13 if BOARD_GOOGLE_TANIKS
+ default 13 if BOARD_GOOGLE_TEREID
+ default 13 if BOARD_GOOGLE_TIVVIKS
+ default 13 if BOARD_GOOGLE_TRULO
+ default 13 if BOARD_GOOGLE_ULDREN
+ default 13 if BOARD_GOOGLE_VELL
+ default 13 if BOARD_GOOGLE_VOLMAR
+ default 13 if BOARD_GOOGLE_XIVU
+ default 13 if BOARD_GOOGLE_XOL
+ default 13 if BOARD_GOOGLE_YAVIKS
+ default 13 if BOARD_GOOGLE_YAVILLA
+ default 13 if BOARD_GOOGLE_ZYDRON

config OVERRIDE_DEVICETREE
default "variants/\$(CONFIG_VARIANT_DIR)/overridetree.cb"

To view, visit change 83493. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9d913bf3da6957ab5c700dd746bc4b5350427d73
Gerrit-Change-Number: 83493
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>