Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41440 )
Change subject: sconfig: Add support for firmware configuration
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41440/14/util/sconfig/main.c
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/41440/14/util/sconfig/main.c@1495
PS14, Line 1495:
I did this intentionally because this allows an override to remove all the probe entries and/or de […]
Ah you are right, it does need to do something in there to assign the override probe to the base device. I'll fix that and update the docs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41440
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8aea63e577d933aea09e0d0b09470929cc96e0de
Gerrit-Change-Number: 41440
Gerrit-PatchSet: 14
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 31 May 2020 21:03:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment