5 comments:
File src/soc/mediatek/mt8183/include/soc/spm.h:
Patch Set #53, Line 591: char path[128];
Why is this here? You don't seem to be using it.
@dawei
File src/soc/mediatek/mt8183/spm.c:
Patch Set #53, Line 268: dyna_load_pcm[index].buf);
It is just for debug purpose only. […]
Debugging message removed.
Patch Set #53, Line 270: /* start of pcm_desc */
Do you mean if we could use the other format to package this FW? If yes, sorry that please understan […]
I think that's understandable.
Patch Set #53, Line 277: snprintf(dyna_load_pcm[index].version,
Something needs to make sure the input string is terminated here. […]
@dawei Do we really need 'version'?
File src/soc/mediatek/mt8183/spm.c:
Patch Set #55, Line 286: assert(offset <= file_size);
@jwerner @hungte
I'm not sure if this is correct.
To view, visit change 34545. To unsubscribe, or for help writing mail filters, visit settings.