Patch Set 55: Code-Review+1
(1 comment)
This comment notes an issue where the build process does not pull in blobs/cpu/intel/stm when pulling in the remainder of the blobs.
View Change
1 comment:
Commit Message:
Patch Set #55, Line 56:
Issue: When the STM is enabled the stm.bin is not properly
loaded causing the build to fail. Workaround, get the
stm.bin from the blobs/cpu/intel/stm directory in the blobs.git
repository
what's this supposed to mean?
Even though stm.bin has incorporated into blobs/cpu/intel/stm. When the build process pulls in the blobs, it does not pull in stm.bin. Cannot tell why, if you look into the blobs repro, stm/stm.bin is the last commit.
So, I had to provide a work around.
To view, visit change 33234. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4adcd92c341162630ce1ec357ffcf8a135785ec
Gerrit-Change-Number: 33234
Gerrit-PatchSet: 55
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Jonathan Zhang <jonzhang@fb.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Comment-Date: Tue, 04 Feb 2020 21:51:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <pgeorgi@google.com>
Gerrit-MessageType: comment