Patch Set 6:

Subrata, please suggest solution for drivers/i2c/max98373_ops and max98357. There are user visible options INCLUDE_SND_MAX98357_DA7219_NHLT and INCLUDE_SND_MAX98373_NHLT but the provided NHLT_BLOB_PATH is invalid.

Are you planning to use Non-HDA audio solution if yes then those blobs are required. i can check where does this blob exist for open source consumption. The same doesn't required for HDA solition


I did not check individual boards, other errors seem to be on pc80/tpm and drivers/usb/acpi here.

View Change

To view, visit change 35086. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb783e2f733d5c65c615e5c1879e3e4c7a83e049
Gerrit-Change-Number: 35086
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 21 Nov 2019 04:18:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment