Attention is currently required from: David Wu, Krishna P Bhat D, Reka Norman, Reka Norman, Stefan Reinauer, Subrata Banik.

6 comments:

Commit Message:
- Patch Set #11, Line 34:
```
         Start address = 0x00004000
         End address = 0x00322fff
```
  I think this should print the actual range, not the enabled range, so these should be 0 (I also left […]
  Thank you for your advise, I've update test result in patchset12.
  Please help to review, thanks!
File util/ifdtool/ifdtool.c:
- Patch Set #11, Line 1749: struct fpsba *fpsba, uint32_t gpr0_offset,
  These arguments are not necessary
  Done, thanks!
- Patch Set #11, Line 1753: enabled_gprd_reg.value = fpsba->pchstrp[gpr0_offset];
  This is not necessary (and doesn't do anything since you overwrite all the fields below).
  Done, thanks!
- Patch Set #11, Line 1786:
```
	union gprd enabled_gprd;
	enabled_gprd = get_enabled_gprd(fpsba, gpr0_offset, image, size);
```
  nit: combine onto one line
  Done, thanks!
- Patch Set #11, Line 1807:
```
	union gprd enabled_gprd;
	enabled_gprd = get_enabled_gprd(fpsba, gpr0_offset, image, size);
```
  nit: combine onto one line
  Done, thanks!
- Patch Set #11, Line 1818: enabled_gprd
  This should be `fpsba->pchstrp[gpr0_offset]` (print the actual range, not the enabled range).
  Done, thanks!

To view, visit change 81928. To unsubscribe, or for help writing mail filters, visit settings.