Patch Set 1:

What about the loglevel approach? You could achieve the same thing with much less code churn.

It's only the same thing if you don't want any logs anywhere. If you want logs in the cbmem console, but not on the serial console, then an approach like this is needed.

Thanks to Kyösti's work in CB:31370, CBMEM console now always prints at DEBUG and you can use the loglevel to control the consoles that actually cost boot time.

Thanks, I hadn't seen that. I'll take a look.

View Change

To view, visit change 33380. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0942634ab8a9fcafdc1ea099721c127202e9f9a
Gerrit-Change-Number: 33380
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 13 Jun 2019 17:19:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment