View Change

7 comments:

• File src/soc/mediatek/common/include/soc/pll_common.h:

  • Patch Set #2, Line 65: N

    Please add a trailing "," for consistency.

  • Patch Set #2, Line 67: unsigned int

    u32

• File src/soc/mediatek/mt8192/pll.c:

  • Patch Set #2, Line 488: return 0;

    Do we want to die() in this case?

  • Patch Set #2, Line 497: setbits32(&mtk_topckgen->clk26cali_0, CLK26CALI_0_TRIGGER);

    Could also we use the SET32_BITFIELDS API for this?

  • Patch Set #2, Line 503: else

    Also add {} for the else block.

  • Patch Set #2, Line 504: output = 0;

    If this is an error case, perhaps at least print an error message here?

  • Patch Set #2, Line 514: (

    No need for the parentheses.

To view, visit change 45402. To unsubscribe, or for help writing mail filters, visit settings.