View Change

3 comments:

• File util/inteltool/iobp.c:

  • Patch Set #3, Line 8: rcba

    this hidden parameter is ugly.

    What is hidden?

  • Patch Set #3, Line 13:

    #define IOBPIRI 0x2330
    #define IOBPD 0x2334
    #define IOBPS 0x2338
    #define  IOBPS_READY 0x0001
    #define  IOBPS_TX_MASK 0x0006
    #define  IOBPS_MASK 0xff00
    #define  IOBPS_READ 0x0600
    #define  IOBPS_WRITE 0x0700
    #define IOBPU 0x233a
    #define  IOBPU_MAGIC 0xf000
    

    Align values with tabs?

    It's a copy of lynxpoint/pch.h.

  • Patch Set #3, Line 90: USBP01

    These registers are officially called U2ECR

    Hmm, searched U2ECR and found https://medium.com/@jacksonchen_43335/bios-read-write-iobp-for-sata-or-usb-aeff9ecd171b, ECR is "electrical control register".

To view, visit change 41473. To unsubscribe, or for help writing mail filters, visit settings.