Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41869 )
Change subject: amd/microcode: Change equivalant ID width to 16bit ......................................................................
Patch Set 3: Code-Review-1
uint16_t processor_rev_id; //This field is 16bit. uint8_t chipset1_rev_id; uint8_t chipset2_rev_id;
I've looked at the fam 16h models 30-3fh BKDG and that matches the existing struct.
In fam17h RV1/PCO PPR the microcode patch equivalent processor ID is 4 bytes long and the chipset revision ID fields don't seem to exist any more. See the PPR section "Microcode Patch Block (MPB)".
So the struct needs to be split into two different versions for pre-zen and zen. in both cases the processor revision ID starts at offset 18h == 24