Attention is currently required from: Alexis Savery, Caveh Jalali, Edward O'Callaghan, Nick Vaccaro, Paul Menzel.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77378?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: google/puff: remove workaround that toggled the #ISOLATE pin
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/77378/comment/0ed47aaa_368c9f74 :
PS7, Line 19: this change to the firmware on a device running 4.19 causes suspend/resume failures, basically reversing the problem. We are upreving the puff kernel to 5.15 so we need this patch, but since
: it is incompatible with 4.19 we will have to take that into consideration when pushing new firmware and potentially will need
Please wrap
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77378?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5eead2d70cd9528b3ca3fadd11f98c0330601324
Gerrit-Change-Number: 77378
Gerrit-PatchSet: 7
Gerrit-Owner: Alexis Savery
asavery@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Alexis Savery
asavery@chromium.org
Gerrit-Comment-Date: Fri, 01 Sep 2023 21:02:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment