Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, Patrick Rudolph.
View Change
1 comment:
Patchset:
Patch Set #1:
All datasheets I looked at say LPC BIOS_CNTL is 8 bits, and
eSPI and SPI BIOS_CNTL is 32 bits. I've never seen 16 bits
so far. It might not matter, though, if the LPC register
doesn't mind bigger reads/writes.
Intel......... eSPI and LPC/SPI are both 32 bits, too. Intel just didn't mention that in the datasheet. Source: refcode and Intel doc#545845.
AFAICS the fast_spi code does get used by eSPI as well bc the spi part of eSPI is compatible and since the BIOS_CONTROL register and the status bit have the same offset, it will get cleared on eSPI, too.
There are google boards with kbl, cnl and others, that could be tested. @Tim @Matt
To view, visit change 50754. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec498674ae70f6590c33a6bf4967876268f2b0c8
Gerrit-Change-Number: 50754
Gerrit-PatchSet: 13
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Sat, 03 Apr 2021 19:31:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment