Patch Set 2:

Should the parent be squashed into this one? I'm confused why this and the parent both bump th revision.

I think the model recent patches have been going with is one plain revbump patch that uprevs to right in front of the dependent patch, and then only pull in the one extra patch that it's actually dependent on in the coreboot-changing patch. So that's what I went with there.

I see. News to me.

Patch set 2:Code-Review +2

View Change

To view, visit change 37315. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2612da0df101cd3c46151dbce728633a39fada1
Gerrit-Change-Number: 37315
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Kitching <kitching@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Joel Kitching <kitching@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 04 Dec 2019 21:29:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment