Patch Set 6:

You must only store defconfigs in this folder, not a complete config.

When I tried shortening a similar CB:32352 to defconfig with " make savedefconfig ", Jenkins still complained with -1 - but about a missing VGABIOS blob:

make[1]: *** No rule to make target 'pci1002,990b.rom'

This config requires "pci1002,9830.rom" for a working internal graphics, and I would like to keep it since I meant this config to be used by the end users as a reference.

To be honest I misunderstood the original purpose of ./configs/ directory: Arthur Heymans said "Those configfiles are there to have jenkins buildtest things, not for general use." But is there any good way to share an example config meant for the end users as a part of ./coreboot/ source tree?

View Change

To view, visit change 33800. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide7529762813944b4f91b2ee8b3ef327b5daffc4
Gerrit-Change-Number: 33800
Gerrit-PatchSet: 6
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin Roth <martinroth@google.com>
Gerrit-CC: Patrick Rudolph <siro@das-labor.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 21 Oct 2019 04:09:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment