View Change
1 comment:
File src/acpi/acpi.c:
Patch Set #2, Line 268: file = acpi_read_table(CONFIG_CBFS_PREFIX "/madt.aml", "APIC");
I didn't know we were doing that for dsdt and slic. […]
so, for now, I'd rather not take on fixing all those problems, but if I take it as an action to fix them *along with this one* can we proceed?
What's the recommended function to use here, btw? I'm happy to make that fix everywhere it's used in this file.
What's your favorite new config variable name? I'm not a huge fan of continuing to add more config variables but if it's seen to be needed I guess we can do it.
To view, visit change 41388. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5e82eb0a82555b7763107e2a1e2a529a0c1b11f
Gerrit-Change-Number: 41388
Gerrit-PatchSet: 3
Gerrit-Owner: ron minnich <rminnich@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-Comment-Date: Thu, 14 May 2020 03:15:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin <adurbin@chromium.org>
Comment-In-Reply-To: ron minnich <rminnich@gmail.com>
Gerrit-MessageType: comment