Patch Set 40:

(1 comment)

the SMI I/O Trap looks a bit suspicious to me; smells like some leftover from vendor firmware. what is that needed for and is the SMI handler for this even in place?

not sure, suspect it may be related to the Apple SMC emulation / Hackintosh support that mjg59 was also working on at the time. I can pull it, just need to find a tester to validate before merging

View Change

1 comment:

• File src/mainboard/51nb/x210/devicetree.cb:

  • Patch Set #40, Line 77: # VR Settings Configuration for 4 Domains

    do the voltage regulator settings need to be in the devicetree? at least for some platforms there we […]

    you're right, it's just using the defaults for KBL-R, I'll remove

To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.