Attention is currently required from: Jayvik Desai, Subrata Banik.
Pranava Y N has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85222?usp=email )
Change subject: mb/google/fatcat: Add EC_SYNC_IRQ and GPIO_PCH_WP for fatcat_ish variant
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/85222/comment/1bb1ea08_24ffe6ae?usp... :
PS2, Line 78: #if !CONFIG(BOARD_GOOGLE_FATCAT) || !CONFIG(BOARD_GOOGLE_FATCATISH)
Shouldn't this be !(CONFIG(BOARD_GOOGLE_FATCAT) || CONFIG(BOARD_GOOGLE_FATCATISH))
or simply use CONFIG(BOARD_GOOGLE_FATCATNUVO) || CONFIG(BOARD_GOOGLE_FATCATITE)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85222?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I977e72a6db99b40a79d37a1b8fe5bee5d98934c7
Gerrit-Change-Number: 85222
Gerrit-PatchSet: 2
Gerrit-Owner: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Thu, 21 Nov 2024 05:44:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pranava Y N
pranavayn@google.com