Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35174 )
Change subject: mb/google/poppy/variant/nocturne: add EC_SYNC_GPIO ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35174/2/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/35174/2/src/mainboard/google/poppy/... PS2, Line 38: GPP_D17_IRQ
EC_ENABLE_SYNC_IRQ is not set for nocturne. Should it be?
It is done here: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/popp...
Kernel uses it here: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads... https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads...