Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30877 )
Change subject: drivers/spi/macronix.c: Add the rest of >=1MB Macronix MX25 chips
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/30877/1/src/drivers/spi/macronix.c
File src/drivers/spi/macronix.c:
https://review.coreboot.org/#/c/30877/1/src/drivers/spi/macronix.c@200
PS1, Line 200: .name = "MX25L3235D", /* MX25L3225D/MX25L3235D/MX25L3236D/MX25L3237D */
This line was already over 80 characters in the past, I didn't change anything for 0x5e16 chip
Yeah, well make jenkins happy ...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30877
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4508a65a5bdcbf58aadf452de5e896fc3c5b1bc3
Gerrit-Change-Number: 30877
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: mikeb mikeb
mikebdp2@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 12 Jan 2019 11:12:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: mikeb mikeb
mikebdp2@gmail.com
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment