Nico Huber submitted this change.

View Change

Approvals:
  build bot (Jenkins): Verified
  Michael Niewöhner: Looks good to me, approved

mb/asrock/h110m: Drop VR configuration from devicetree

Drop VR configuration since it matches the platform defaults.

Change-Id: I92007f4ff9d093c9573bb1ee13e64eb2f38af4f4
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49188
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
---
M src/mainboard/asrock/h110m/devicetree.cb
1 file changed, 0 insertions(+), 67 deletions(-)

diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb
index 77ff9ef..4cb8735 100644
--- a/src/mainboard/asrock/h110m/devicetree.cb
+++ b/src/mainboard/asrock/h110m/devicetree.cb
@@ -34,73 +34,6 @@
 	# SLP_A Minimum Assertion Width. Values 0: 0ms, 1: 4s, 2: 98ms, 3: 2s
 	register "PmConfigSlpAMinAssert" = "0x03"
 
-	# VR Settings Configuration
-	#+----------------+-------+-------+-------------+-------+
-	#| Domain/Setting |  SA   |  IA   | GT Unsliced |  GT   |
-	#+----------------+-------+-------+-------------+-------+
-	#| Psi1Threshold  | 20A   | 20A   | 20A         | 20A   |
-	#| Psi2Threshold  | 4A    | 5A    | 5A          | 5A    |
-	#| Psi3Threshold  | 1A    | 1A    | 1A          | 1A    |
-	#| Psi3Enable     | 1     | 1     | 1           | 1     |
-	#| Psi4Enable     | 1     | 1     | 1           | 1     |
-	#| ImonSlope      | 0     | 0     | 0           | 0     |
-	#| ImonOffset     | 0     | 0     | 0           | 0     |
-	#| IccMax*        | 0     | 0     | 0           | 0     |
-	#| VrVoltageLimit | 1.52V | 1.52V | 1.52V       | 1.52V |
-	#+----------------+-------+-------+-------------+-------+
-	# * - is set automatically in the vr_config.c
-	register "domain_vr_config[VR_SYSTEM_AGENT]" = "{
-		.vr_config_enable = 1, \
-		.psi1threshold = VR_CFG_AMP(20), \
-		.psi2threshold = VR_CFG_AMP(4), \
-		.psi3threshold = VR_CFG_AMP(1), \
-		.psi3enable = 1, \
-		.psi4enable = 1, \
-		.imon_slope = 0x0, \
-		.imon_offset = 0x0, \
-		.icc_max = 0x0, \
-		.voltage_limit = 1520 \
-	}"
-
-	register "domain_vr_config[VR_IA_CORE]" = "{
-		.vr_config_enable = 1, \
-		.psi1threshold = VR_CFG_AMP(20), \
-		.psi2threshold = VR_CFG_AMP(5), \
-		.psi3threshold = VR_CFG_AMP(1), \
-		.psi3enable = 1, \
-		.psi4enable = 1, \
-		.imon_slope = 0x0, \
-		.imon_offset = 0x0, \
-		.icc_max = 0x0, \
-		.voltage_limit = 1520 \
-	}"
-
-	register "domain_vr_config[VR_GT_UNSLICED]" = "{
-		.vr_config_enable = 1, \
-		.psi1threshold = VR_CFG_AMP(20), \
-		.psi2threshold = VR_CFG_AMP(5), \
-		.psi3threshold = VR_CFG_AMP(1), \
-		.psi3enable = 1, \
-		.psi4enable = 1, \
-		.imon_slope = 0x0, \
-		.imon_offset = 0x0, \
-		.icc_max = 0x0 ,\
-		.voltage_limit = 1520 \
-	}"
-
-	register "domain_vr_config[VR_GT_SLICED]" = "{
-		.vr_config_enable = 1, \
-		.psi1threshold = VR_CFG_AMP(20), \
-		.psi2threshold = VR_CFG_AMP(5), \
-		.psi3threshold = VR_CFG_AMP(1), \
-		.psi3enable = 1, \
-		.psi4enable = 1, \
-		.imon_slope = 0x0, \
-		.imon_offset = 0x0, \
-		.icc_max = 0x0, \
-		.voltage_limit = 1520 \
-	}"
-
 	# PL2 override 91W
 	register "power_limits_config" = "{
 		.tdp_pl2_override = 91,

To view, visit change 49188. To unsubscribe, or for help writing mail filters, visit settings.