10 comments:
File src/soc/intel/alderlake/Makefile.inc:
Please keep entries sorted in alphabetical order
File src/soc/intel/alderlake/acpi.c:
Patch Set #3, Line 23: #include <string.h>
<string.h> not used. […]
Untrue. `memcpy` appears in this file.
Also, `bool` is used, so just include <types.h>
Patch Set #3, Line 181: uintptr_t pmc_bar = soc_read_pmc_base();
no need for a temporary variable
Patch Set #3, Line 188: uint64_t gfxvtbar = MCHBAR64(GFXVTBAR) & VTBAR_MASK;
Many things here can be const
Patch Set #3, Line 233: TBT0BAR
You could redefine these registers as follows:
#define TBTxBAR(x) (0x7888 + (x) * 8)
This way, the macros can be easily used in loops 😊
/* Add RMRR entry */
const unsigned long tmp = current;
current += acpi_create_dmar_rmrr(current, 0,
sa_get_gsm_base(), sa_get_tolud_base() - 1);
current += acpi_create_dmar_ds_pci(current, 0, 2, 0);
acpi_dmar_rmrr_fixup(tmp, current);
Shouldn't this be skipped if the IGD is disabled?
File src/soc/intel/alderlake/chip.c:
Patch Set #3, Line 118: rotine
ro*u*tine
/* Snapshot the current GPIO IRQ polarities. FSP is setting a
* default policy that doesn't honor boards' requirements. */
itss_snapshot_irq_polarities(GPIO_IRQ_START, GPIO_IRQ_END);
Does this still apply to ADL?
File src/soc/intel/alderlake/pmutil.c:
<types.h>
File src/soc/intel/alderlake/smmrelocate.c:
Patch Set #3, Line 3: #include <types.h>
I prefer to keep #includes sorted alphabetically.
To view, visit change 45759. To unsubscribe, or for help writing mail filters, visit settings.