Attention is currently required from: Arthur Heymans, Arthur Heymans, Philipp Hug.
4 comments:
Patchset:
I had a few questions.
File src/arch/riscv/ramdetect.c:
Patch Set #9, Line 21: #define insn_size 4
Is this true in an era of compact instruction extension? I no longer know.
Should insn_size be define somewhere in <arch/...>?
Can we ensure we never build with compact instrutions enabled? I'd be fine with that.
Patch Set #9, Line 35: uintptr_t addr = dram_start + (size * MiB) - sizeof(uint32_t);
Should we make sure dram_start is 32-bit aligned, in case of someone doing something silly? it would be a pain to take an alignment trap here. Or should the probe be for read8, just to be sure?
To view, visit change 36486. To unsubscribe, or for help writing mail filters, visit settings.