7 comments:
File src/soc/mediatek/common/include/soc/pll_common.h:
Please add a trailing "," for consistency.
Done
Patch Set #2, Line 67: unsigned int
u32
Done
File src/soc/mediatek/mt8192/pll.c:
Patch Set #2, Line 488: return 0;
Do we want to die() in this case?
Done
Patch Set #2, Line 497: setbits32(&mtk_topckgen->clk26cali_0, CLK26CALI_0_TRIGGER);
Could also we use the SET32_BITFIELDS API for this?
Done
Also add {} for the else block.
Done
Patch Set #2, Line 504: output = 0;
If this is an error case, perhaps at least print an error message here?
Done
No need for the parentheses.
Done
To view, visit change 45402. To unsubscribe, or for help writing mail filters, visit settings.