Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38741 )
Change subject: soc/intel/cannonlake: Add tdc config for CML ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38741/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38741/12//COMMIT_MSG@16 PS12, Line 16: FSP log How do you check that? Is that in the coreboot console output, for example `cbmem -1`?
https://review.coreboot.org/c/coreboot/+/38741/12/src/soc/intel/cannonlake/i... File src/soc/intel/cannonlake/include/soc/vr_config.h:
https://review.coreboot.org/c/coreboot/+/38741/12/src/soc/intel/cannonlake/i... PS12, Line 58: * Remove.