EricR Lai has uploaded this change for review.

View Change

drivers/generic/alc1015: Add HID to support alc1019

ALC1019 will use the APCI campitable and share the same driver with
ALC1015. Add HID to support more campitable ICs.

BUG=b:195891240
TEST=: ALC1019P driver can probe properly.

Signed-off-by: Eric Lai <ericr_lai@compal.corp-partner.google.com>
Change-Id: I3e98297f3a39048b24d61e61ca95c60cd2037eb5
---
M src/drivers/generic/alc1015/alc1015.c
M src/drivers/generic/alc1015/chip.h
2 files changed, 6 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/56877/1
diff --git a/src/drivers/generic/alc1015/alc1015.c b/src/drivers/generic/alc1015/alc1015.c
index 920b8af..ca685d6 100644
--- a/src/drivers/generic/alc1015/alc1015.c
+++ b/src/drivers/generic/alc1015/alc1015.c
@@ -25,7 +25,10 @@
acpigen_write_scope(scope);
acpigen_write_device(name);

- acpigen_write_name_string("_HID", "RTL1015");
+ if (config->hid)
+ acpigen_write_name_string("_HID", config->hid);
+ else
+ acpigen_write_name_string("_HID", "RTL1015");
acpigen_write_name_integer("_UID", 0);
acpigen_write_name_string("_DDN", dev->chip_ops->name);
acpigen_write_STA(acpi_device_status(dev));
diff --git a/src/drivers/generic/alc1015/chip.h b/src/drivers/generic/alc1015/chip.h
index 4c01e7c..fa84177 100644
--- a/src/drivers/generic/alc1015/chip.h
+++ b/src/drivers/generic/alc1015/chip.h
@@ -3,6 +3,6 @@
#include <acpi/acpi_device.h>

struct drivers_generic_alc1015_config {
- /* SDMODE GPIO */
- struct acpi_gpio sdb;
+ const char *hid; /* ACPI _HID */
+ struct acpi_gpio sdb; /* SDMODE GPIO */
};

To view, visit change 56877. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e98297f3a39048b24d61e61ca95c60cd2037eb5
Gerrit-Change-Number: 56877
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-MessageType: newchange