2 comments:
So is this an Intel-only tech? If so, the changes to this file should be
moved to the .get_smm_info and .relocation_handler callbacks.
Patch Set #3, Line 1056: * value of 0x400 for this value.
Patrick Rudolph noted in a previous comment: "It looks like coreboot assumes 0x400 as safe value fo […]
You have to be careful what code you read. smmhandler.S, smmhandler.c,
smmrelocate.S are for non-TSEG (very old) platforms. For TSEG platforms,
focus on mp_init.c, and smm/smm_*.
I don't think it's the alignment that breaks things, it's the absolute size.
Have a look at smm_module_setup_stub(). It uses SMM_DEFAULT_SIZE. I guess
that should be made a parameter. I would start by adding an overflow check
before line 205.
To view, visit change 38734. To unsubscribe, or for help writing mail filters, visit settings.