40 comments:
File src/mainboard/sifive/hifive-unleashed/media.c:
Patch Set #1, Line 43: if (sd_copy((spi_ctrl*)FU540_QSPI2, tmp, lba, 1) != 0) {
"(foo*)" should be "(foo *)"
Patch Set #1, Line 43: if (sd_copy((spi_ctrl*)FU540_QSPI2, tmp, lba, 1) != 0) {
braces {} are not necessary for single statement blocks
Patch Set #1, Line 57: if (sd_copy((spi_ctrl*)FU540_QSPI2, tmp, lba, 1) != 0) {
"(foo*)" should be "(foo *)"
Patch Set #1, Line 57: if (sd_copy((spi_ctrl*)FU540_QSPI2, tmp, lba, 1) != 0) {
braces {} are not necessary for single statement blocks
Patch Set #1, Line 64: size_t size = (last_lba - has_end) - (first_lba + has_begin) + 1;
line over 80 characters
Patch Set #1, Line 66: if (sd_copy((spi_ctrl*)FU540_QSPI2, dest + o, lba, size) != 0) {
line over 80 characters
Patch Set #1, Line 66: if (sd_copy((spi_ctrl*)FU540_QSPI2, dest + o, lba, size) != 0) {
"(foo*)" should be "(foo *)"
Patch Set #1, Line 66: if (sd_copy((spi_ctrl*)FU540_QSPI2, dest + o, lba, size) != 0) {
braces {} are not necessary for single statement blocks
Patch Set #1, Line 75: if (sd_copy((spi_ctrl*)FU540_QSPI2, tmp, lba, 1) != 0) {
"(foo*)" should be "(foo *)"
Patch Set #1, Line 75: if (sd_copy((spi_ctrl*)FU540_QSPI2, tmp, lba, 1) != 0) {
braces {} are not necessary for single statement blocks
Patch Set #1, Line 97: switch(read32((uint32_t *)FU540_MSEL)) {
space required before the open parenthesis '('
Patch Set #1, Line 108: void boot_device_init()
Bad function definition - void boot_device_init() should probably be void boot_device_init(void)
Patch Set #1, Line 110: switch(read32((uint32_t *)FU540_MSEL)) {
space required before the open parenthesis '('
Patch Set #1, Line 117: sd_init((spi_ctrl*)FU540_QSPI2, clock_get_tlclk_khz());
"(foo*)" should be "(foo *)"
Patch Set #1, Line 118: mmap_helper_device_init(&sd_mdev, _cbfs_cache, _cbfs_cache_size);
line over 80 characters
File src/soc/sifive/fu540/include/soc/sd.h:
Patch Set #1, Line 35: int sd_init(spi_ctrl* spi, unsigned int input_clk_hz);
"foo* bar" should be "foo *bar"
Patch Set #1, Line 36: int sd_copy(spi_ctrl* spi, void* dst, uint32_t src_lba, size_t size);
"foo* bar" should be "foo *bar"
Patch Set #1, Line 36: int sd_copy(spi_ctrl* spi, void* dst, uint32_t src_lba, size_t size);
"foo* bar" should be "foo *bar"
File src/soc/sifive/fu540/sd.c:
Patch Set #1, Line 66: static inline uint8_t sd_dummy(spi_ctrl* spi)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 72: static int sd_cmd(spi_ctrl* spi, uint8_t cmd, uint32_t arg, uint8_t crc)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 89: if (!(r & 0x80)) {
braces {} are not necessary for single statement blocks
Patch Set #1, Line 97: static inline void sd_cmd_end(spi_ctrl* spi)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 104: static void sd_poweron(spi_ctrl* spi, unsigned int input_clk_khz)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 121: // SD CMD pin is the same pin as SPI DI, so CMD = 0xff means assert DI high
line over 80 characters
Patch Set #1, Line 133: static int sd_cmd0(spi_ctrl* spi)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 136: rc = (sd_cmd(spi, SD_CMD(SD_CMD_GO_IDLE_STATE), 0, 0x95) != SD_RESPONSE_IDLE);
line over 80 characters
Patch Set #1, Line 145: static int sd_cmd8(spi_ctrl* spi)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 150: rc = (sd_cmd(spi, SD_CMD(SD_CMD_SEND_IF_COND), 0x000001AA, 0x87) != SD_RESPONSE_IDLE);
line over 80 characters
Patch Set #1, Line 163: static void sd_cmd55(spi_ctrl* spi)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 173: static int sd_acmd41(spi_ctrl* spi)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 178: r = sd_cmd(spi, SD_CMD(SD_CMD_APP_SEND_OP_COND), 0x40000000, 0x77); /* HCS = 1 */
line over 80 characters
Patch Set #1, Line 189: static int sd_cmd58(spi_ctrl* spi)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 192: // to issue this command if we only support SD cards that support SDHC mode.
line over 80 characters
Patch Set #1, Line 208: static int sd_cmd16(spi_ctrl* spi)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 239: //int sd_init(spi_ctrl* spi, unsigned int input_clk_khz, int skip_sd_init_commands)
line over 80 characters
Patch Set #1, Line 240: int sd_init(spi_ctrl* spi, unsigned int input_clk_khz)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 260: int sd_copy(spi_ctrl* spi, void* dst, uint32_t src_lba, size_t size)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 260: int sd_copy(spi_ctrl* spi, void* dst, uint32_t src_lba, size_t size)
"foo* bar" should be "foo *bar"
Patch Set #1, Line 273: if (sd_cmd(spi, SD_CMD(SD_CMD_READ_BLOCK_MULTIPLE), src_lba, c) != 0x00) {
line over 80 characters
Patch Set #1, Line 283: while (sd_dummy(spi) != SD_DATA_TOKEN);
trailing statements should be on next line
To view, visit change 30901. To unsubscribe, or for help writing mail filters, visit settings.