Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Mario Scheithauer: Looks good to me, approved Lean Sheng Tan: Looks good to me, approved
mb/siemens/mc_ehl: Disable PMC low power modes

All the mainboard variants of mc_ehl do not use the external switches
for the bypass rails. Disable the matching UPDs and all the low power
modes of the PMC.

Change-Id: I08f4effe5c4d5845bed01dfe1bd1251c58012b7f
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58895
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-by: Lean Sheng Tan <lean.sheng.tan@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/siemens/mc_ehl/mainboard.c
1 file changed, 5 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/siemens/mc_ehl/mainboard.c b/src/mainboard/siemens/mc_ehl/mainboard.c
index fc03115..5c8f584 100644
--- a/src/mainboard/siemens/mc_ehl/mainboard.c
+++ b/src/mainboard/siemens/mc_ehl/mainboard.c
@@ -125,6 +125,11 @@

/* Disable P-States */
params->MaxRatio = 0;
+
+ /* Disable PMC low power modes */
+ params->PmcLpmS0ixSubStateEnableMask = 0;
+ params->PmcV1p05PhyExtFetControlEn = 0;
+ params->PmcV1p05IsExtFetControlEn = 0;
}

static void mainboard_init(void *chip_info)

To view, visit change 58895. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08f4effe5c4d5845bed01dfe1bd1251c58012b7f
Gerrit-Change-Number: 58895
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: Lean Sheng Tan <lean.sheng.tan@intel.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer@siemens.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged