Attention is currently required from: Dolan Liu, Elyes Haouas, Eric Lai, Jianeng Ceng, Subrata Banik.
3 comments:
File src/drivers/i2c/rt5645/rt5645.c:
Patch Set #23, Line 42: 10EC5650
any reason why are we hard coding this ?
agreed, this should only be the fallback if not specified in the chip definition
Patch Set #23, Line 46: acpigen_write_STA(acpi_device_status(dev));
we might want to set this to hidden if present, since there won't be a Windows driver for this ACPI device, and it would otherwise cause an unknown device to be listed under Device Manager
Patch Set #23, Line 93: static char name[5];
why is this 5 char? shouldn't this be '10EC5650' normally?
To view, visit change 81773. To unsubscribe, or for help writing mail filters, visit settings.