6 comments:
Remove postcar support
completely from Makefile.inc.
This is not really true for the change anymore.
Can you please add appropriate BUG= to commit message?
File src/soc/amd/picasso/Makefile.inc:
Patch Set #11, Line 208: $(obj)/cbfs/fallback
$(objcbfs)
Patch Set #11, Line 208: bootblock.elf
Don't you really want to just use bootblock.bin here?
Patch Set #11, Line 209: $(CONFIG_C_ENV_BOOTBLOCK_SIZE)
I believe you can just use file-size bootblock.bin here?
File src/soc/amd/picasso/bootblock/bootblock.c:
Patch Set #11, Line 24: pre_init(
These are named in a weird way. bootblock_soc_early_init() calls function with *_pre_init() and bootblock_soc_init() calls functions with *_early_init(). I understand these were not added in this CL. But just noting the naming inconsistency.
To view, visit change 37490. To unsubscribe, or for help writing mail filters, visit settings.