Paul Fagerburg submitted this change.
mb/google/guybrush: Use open drain eSPI alerts
Remove the override in guybrush devicetree that configured in-band eSPI
alerts. This will result in guybrush using dedicated open-drain eSPI
alerts. Guybrush boards must be reworked to connect the eSPI alert line,
otherwise they will not boot with this change
BUG=b:198596430
TEST=Boot on reworked guybrush
BRANCH=None
Change-Id: I185eec773336fb662d9fe7f4c11991813e4d7cd6
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57778
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/guybrush/variants/guybrush/overridetree.cb
1 file changed, 0 insertions(+), 3 deletions(-)
diff --git a/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb b/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb
index 41b3733..aefdd3d 100644
--- a/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb
+++ b/src/mainboard/google/guybrush/variants/guybrush/overridetree.cb
@@ -169,7 +169,4 @@
end
end
- # TODO(b/198596430): Disable in-band alerts after majority boards are reworked
- register "common_config.espi_config.alert_pin" = "ESPI_ALERT_PIN_IN_BAND"
-
end # chip soc/amd/cezanne
To view, visit change 57778. To unsubscribe, or for help writing mail filters, visit settings.