Does not rise much confidence...

Even if this option does not seem too useful to you at the moment: it already exists and has a nice name, so we could take it over by writing useful code for it.

No. Don't invent new purpose for old Kconfig.

AFAIK it is forbidden to route the IO and MMIO regions related to VGA Option Rom to two different PCI functions. Not sure how you could even run two option roms without redoing the routing in between.

I think the intention here has been to make sure that the graphics card, for which we have option rom included in CBFS, gets the routing setup. Then again, the code is multi-node/hypertransport related so all that may be leftovers from fam15 model0 (before TN/RL).

View Change

To view, visit change 31448. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3269a0911e86ea07014484365c7c830485e52ec
Gerrit-Change-Number: 31448
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Patrick Rudolph <siro@das-labor.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 18 Feb 2019 20:05:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment