14 comments:
no `a`
Done
nit: space before `(`
Done
Patch Set #5, Line 15: specifc
typo: specific
Done
nit: SMI
Done
Patch Set #5, Line 23: must is
`must` or `is`? Pick one of them, but not both 😄
Done
nit: SMM
Done
File Documentation/releases/coreboot-4.13-relnotes.md:
trailing whitespace
Done
an extensive
number
I'd mention numbers here, e.g. […]
Done
trailing whitespace
Done
Patch Set #5, Line 775: cpus = 1;
Instead of serializing relocation, could we use a smaller number instead? […]
This would be a performance and optimization setting. SMM is already very difficult to debug. How about we save this for a future patch?
This changes the number of concurrent save states for the !X86_SMM_LOADER_VERSION2 case.
It shouldn't unless I missed something. On line 794:
int cpus = num_cpus;
will take care of it for the older loader version.
nit: CPUs
Done
nit: CPUs
Done
File src/cpu/x86/smm/smm_module_loaderv2.c:
Patch Set #2, Line 123: not enough space in SMM to setup all CPUs
From reading the statements on line 112, 114 and 116, the error message in line 123 is somewhat misl […]
Done. Clarification added.
To view, visit change 43684. To unsubscribe, or for help writing mail filters, visit settings.