Nico Huber submitted this change.

View Change

Approvals: Nico Huber: Verified Angel Pons: Looks good to me, approved
Makefile: Always disable warnings for out-of-order record fields

We added this as a GCC 10 quirk, but of course by now there are many
more versions with this flag. Stable GCC 10.1 was released almost 4
years ago and libhwbase is mostly used with coreboot's toolchain and
newer ones. So we don't have to keep compatibility with older GCC
releases.

Change-Id: I1131ebbdde71cd6223a9ea650512eec601401cc3
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/libhwbase/+/82052
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M Makefile
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index fb4c43c..e8d864e 100644
--- a/Makefile
+++ b/Makefile
@@ -43,8 +43,6 @@
CC = $(CROSS_COMPILE)gcc
GNATBIND = $(CROSS_COMPILE)gnatbind

-GCC_MAJOR = $(shell echo __GNUC__ | $(CC) -E - 2>/dev/null | tail -1)
-
CFLAGS += -Wuninitialized -Wall -Werror
CFLAGS += -pipe -g
CFLAGS += -Wstrict-aliasing -Wshadow
@@ -89,8 +87,7 @@
# .Y Disable information messages for why package spec needs body:
# Those messages are annoying. But don't forget to enable those,
# if you need the information.
-ADAFLAGS += -gnatwa.eeD.HHTU.U.W.Y
-ADAFLAGS += $(if $(filter 10,$(GCC_MAJOR)),-gnatw_R)
+ADAFLAGS += -gnatwa.eeD.HHTU.U.W.Y_R
# Disable style checks for now
ADAFLAGS += -gnatyN


To view, visit change 82052. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libhwbase
Gerrit-Branch: main
Gerrit-Change-Id: I1131ebbdde71cd6223a9ea650512eec601401cc3
Gerrit-Change-Number: 82052
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: merged